Refactored immutable structs into record types.#3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several immutable struct types to use C# record syntax, significantly reducing boilerplate code while maintaining the same functionality. The changes focus on eliminating manual implementations of equality operators, hash code generation, and property definitions.
- Converted 20+ struct types to record struct types with auto-implemented properties and equality
- Added compatibility support for .NET Standard 2.1 through IsExternalInit class
- Updated property access patterns to match the new positional parameter naming
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Forge/Effects/Stacking/StackingData.cs | Converted to record struct, removed manual equality/hash implementations |
| Forge/Effects/Periodic/PeriodicData.cs | Converted to record struct, simplified to single-line declaration |
| Forge/Effects/Modifiers/Modifier.cs | Converted to record struct, removed boilerplate code |
| Forge/Effects/ModifierEvaluatedData.cs | Converted struct to record struct |
| Forge/Effects/Magnitudes/*.cs | Multiple magnitude types converted to record structs |
| Forge/Effects/Duration/DurationData.cs | Converted to record struct with updated property name |
| Forge/Effects/ActiveEffect.cs | Updated property access to use new naming (AttributeOverride.Value) |
| Forge/Attributes/*.cs | Converted attribute-related structs to records and optimized EntityAttribute |
| Forge/Compatibility/IsExternalInit.cs | Added compatibility support for .NET Standard 2.1 |
| Multiple test files | Updated constructor calls to use new positional parameter names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored several immutable structs into record types, significantly reducing boilerplate code.
Applied minor optimizations while ensuring no changes to existing functionality.