Update autotools configuration to include all distribution files #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow `make dist` and `make distcheck` to succeed (tested on
Debian 13 Trixie), although CPPFLAGS needs some extra parameters, especially
when building outside the source tree (such as when running `make distcheck`).
E.g.
./configure CPPFLAGS='-I$(top_srcdir)'
and for `make distcheck`
DISTCHECK_CONFIGURE_FLAGS='CPPFLAGS=-I../../.. \
--disable-install-cmake-modules' make distcheck
Including these flags in `AM_CPPFLAGS` in the relevant `Makefile.am` files
should be harmless and simplify any instructions. I've tried to make as few
changes as necessary. Additionally I have not sorted any of the lists of
files to make merge conflicts easier to handle. Ideally they should be sorted
after a successful merge.
`make dist` creates both tar and zip distribution files. That can be changed
in `AM_INIT_AUTOMAKE` in `configure.ac`. The distribution files contain the
same contents as currently in the distribution files created by Github.
The advantage of using the autotools distribution file is that the end user
does not need to install autotools etc. Nor will there be autotool version
conflicts. The only dependencies to build on Debian 13 (Trixie) are
`pkg-config g++ libncurses-dev`. `libcppunit-dev` would be required to build
the unit tests.
I also included an option to disable attempting to install CMake modules as
this causes `make distcheck` to fail.
Owner
|
Great job! I’m especially pleased that you followed the coding standard exactly as required. |
Owner
|
Okay, and now in alphabetical order again (c7f2925). |
Contributor
Author
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow
make distandmake distcheckto succeed (tested on Debian 13 Trixie), although CPPFLAGS needs some extra parameters, especially when building outside the source tree (such as when runningmake distcheck). E.g.and for
make distcheckIncluding these flags in
AM_CPPFLAGSin the relevantMakefile.amfiles should be harmless and simplify any instructions. I've tried to make as few changes as necessary. Additionally I have not sorted any of the lists of files to make merge conflicts easier to handle. Ideally they should be sorted after a successful merge.make distcreates both tar and zip distribution files. That can be changed inAM_INIT_AUTOMAKEinconfigure.ac. The distribution files contain the same contents as currently in the distribution files created by Github.The advantage of using the autotools distribution file is that the end user does not need to install autotools etc. Nor will there be autotool version conflicts. The only dependencies to build on Debian 13 (Trixie) are
pkg-config g++ libncurses-dev.libcppunit-devwould be required to build the unit tests.I also included an option to disable attempting to install CMake modules as this causes
make distcheckto fail.