Conversation
| #if defined(_MSC_VER) && _MSC_VER < 1700 | ||
| #ifndef for | ||
| #define for if(false) {} else for | ||
| #endif |
There was a problem hiding this comment.
This was back from the VS 6 days (_MSC_VER < 1300). We can drop the whole block.
| #if defined(_MSC_VER) && _MSC_VER < 1700 | ||
| #ifndef for | ||
| #define for if(false) {} else for | ||
| #endif |
There was a problem hiding this comment.
This was back from the VS 6 days (_MSC_VER < 1300). We can drop the whole block.
| else if (Converter::SafeDownCast(named)) | ||
| { | ||
| named->SetName("{operator}"); | ||
| } |
There was a problem hiding this comment.
Please match the existing indentation scheme (2 spaces instead of a TAB).
|
I have been trying to get to reviewing this... I have a build of https://github.com/CastXML/CastXMLSuperbuild going on my Mac right now, and will get a Windows one going too. I need that to succeed first or to install a pre-built binary of castxml before I can get this one verified on Windows. I'll keep plugging away at it in my spare time, but it might still take me a couple more weeks before I can effectively review things here. |
3 participants
Changes needed to build Mummy with VS2017