Added support for PS5USB controllers#12
Open
josephduchesne wants to merge 2 commits intogdsports:masterfrom
Open
Added support for PS5USB controllers#12josephduchesne wants to merge 2 commits intogdsports:masterfrom
josephduchesne wants to merge 2 commits intogdsports:masterfrom
Conversation
Added initial support for PS5 controllers by creating a combination of the PS4 controller class and Ludwig Füchsl's DualSense Windows driver https://github.com/Ohjurot/DualSense-Windows
|
@josephduchesne Nice to see that! From my side the comments with the attribution and license in the source code is totally fine for this project. |
Lauszus
reviewed
Jan 17, 2021
Lauszus
reviewed
Jan 17, 2021
Lauszus
reviewed
Jan 17, 2021
| uint8_t battery : 4; | ||
| uint8_t dummy3 : 1; | ||
| uint8_t battery_full : 1; | ||
| uint8_t dummy4 : 2; |
There was a problem hiding this comment.
I do not think this is correct. These are all 0's on my controller except for the 1st bit, which seems to be used for the microphone. I do not know about the battery_full bit though, as I'm not sure if my controller is fully charged or not.
There was a problem hiding this comment.
@josephduchesne what is your take on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added initial support for PS5 controllers by creating a combination of the PS4 controller class and Ludwig Füchsl's DualSense Windows driver https://github.com/Ohjurot/DualSense-Windows
This supports all of the feature's that @Ohjurot supported in his driver, including 3 different haptic modes.
Since the force feedback in the triggers is pretty complicated, I used the DualSense Windows functions and datastructures with minimual modification, which is why the PS5Trigger.h and PS5Trigger.cpp files retain their source license and copyright (MIT license). I don't believe that this is a problem given that the explicitly copied code sections are all properly licensed and attributed as far as I can tell.
I have only included the USB class, however it should be relatively straight forward to create a Bluetooth version. I just don't have a great hardware setup for that, and my use case prefers USB.