feat: add support of @testing-library/dom queries#1092
feat: add support of @testing-library/dom queries#1092talkenson wants to merge 5 commits intogemini-testing:masterfrom
Conversation
talkenson
force-pushed
the
feat/add-dtl
branch
4 times, most recently
from
7195292 to
cddccaf
Compare
shadowusr
left a comment
shadowusr
left a comment
There was a problem hiding this comment.
Thoughts I have after taking a look:
-
Let's come up with a better configuration API.
browser.configureDTLisn't a good choice for multiple reasons (you need browser instance to configure, naming feels off, you can't set this globally) -
We need to check an important edge-case: what if users followed through with our docs and uses wdio-testing-library? Then if he updates, tests will be failing, because of duplicate commands. We need to check this
-
We need to check that timeouts for
find*queries are being configured correctly. For example, how timeouts specified in our testplane config, interact with those. If they don't it's an issue, because they should affect testing-library timeouts.
talkenson
force-pushed
the
feat/add-dtl
branch
2 times, most recently
from
a8d4910 to
7ecc7f7
Compare
shadowusr
left a comment
shadowusr
left a comment
There was a problem hiding this comment.
Also, I still see no signs that we respect timeouts set in testplane config in find* queries (see point 3 of my previous comment)
|
I think now it looks okay, but feel free to ask for more changes |
2 participants
No description provided.