Open
Conversation
commit: |
KuznetsovRoman
requested changes
Oct 7, 2025
Comment on lines
+21
to
+22
| // Удаляем стектрейс про EPIPE, который не нужен пользователю | ||
| delete this.stack; |
Member
There was a problem hiding this comment.
By deleting "stack" property you are producing invalid Error object:
Specs: https://nodejs.org/api/errors.html#errorstack
If you want to override stack, make it comply node.js stacktraces:
The first line is formatted as : , and is followed by a series of stack frames (each line beginning with "at ").
So, we could overwrite it with SingleTestModeError: ${message}
Member
Author
There was a problem hiding this comment.
yes, but in that case the message will be duplicated
Member
There was a problem hiding this comment.
If it doesn't lead to an error, its fine, i guess
KuznetsovRoman
approved these changes
Nov 5, 2025
Member
|
This is probably fixed in a more general way over here — #1188 I'll check that my fixes work for this case as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.