Skip to content

test: address tests failing locally#537

Merged
ajbozarth merged 6 commits intogenerative-computing:mainfrom
ajbozarth:tests
Feb 13, 2026
Merged

test: address tests failing locally#537
ajbozarth merged 6 commits intogenerative-computing:mainfrom
ajbozarth:tests

Conversation

@ajbozarth
Copy link
Contributor

@ajbozarth ajbozarth commented Feb 12, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

An assortment of test fixes to get uv run pytest passing both locally on my Mac and on bluevela.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth self-assigned this Feb 12, 2026
@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Feb 12, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth
Copy link
Contributor Author

Just merged with main and found that the recent commit from #288 caused mypy errors on Mac since vllm can't be installed (as noted in that PR)

I added the fix in 46ccfcc to address it, it only occurs when running mypy on macOS (darwin) since the vllm dep is not installed and thus the type stubs are not installed for mypy to use

@@ -1,3 +1,5 @@
# pytest: skip_always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we always skipping this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on the langchain_community package to run, but that package conflicts with our current dependencies, if we try to add it, even as a optional dependency, it causes a version conflict that can't be solved unless we don't install other optional dependencies, which would break other tests/examples. This can possibly be solved once we address #453

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we open an issue for that (or add it to 453), just so we can track why we're skipping somewhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the conflicting package? And can you please add a note in the file as well explaining why it's always skipped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into it early in my work on this, I'll see if I can recreate the conflict loop I got stuck on and have Bob write up an issue on it and I'll link it to #453

I'll also add a comment linking to that issue once I've opened it, for now I've disabled auto-merge so if everything else looks good feel free to approve and I'll merge once that comment is pushed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems the updates in #288 actually removed the source of the conflicts so I just pushed an update to reenable this and update the optional dependencies to include it

@jakelorocco if you could take a look?

I also noticed #487 and double checked that my update in 46ccfcc was still necessary (it is)

@ajbozarth ajbozarth added this pull request to the merge queue Feb 13, 2026
Merged via the queue into generative-computing:main with commit 6f3e131 Feb 13, 2026
4 checks passed
@ajbozarth ajbozarth deleted the tests branch February 13, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants