test: address tests failing locally#537
Conversation
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
Just merged with main and found that the recent commit from #288 caused mypy errors on Mac since vllm can't be installed (as noted in that PR) I added the fix in 46ccfcc to address it, it only occurs when running mypy on macOS (darwin) since the vllm dep is not installed and thus the type stubs are not installed for mypy to use |
| @@ -1,3 +1,5 @@ | |||
| # pytest: skip_always | |||
There was a problem hiding this comment.
why are we always skipping this one?
There was a problem hiding this comment.
This depends on the langchain_community package to run, but that package conflicts with our current dependencies, if we try to add it, even as a optional dependency, it causes a version conflict that can't be solved unless we don't install other optional dependencies, which would break other tests/examples. This can possibly be solved once we address #453
There was a problem hiding this comment.
could we open an issue for that (or add it to 453), just so we can track why we're skipping somewhere
There was a problem hiding this comment.
What is the conflicting package? And can you please add a note in the file as well explaining why it's always skipped.
There was a problem hiding this comment.
I ran into it early in my work on this, I'll see if I can recreate the conflict loop I got stuck on and have Bob write up an issue on it and I'll link it to #453
I'll also add a comment linking to that issue once I've opened it, for now I've disabled auto-merge so if everything else looks good feel free to approve and I'll merge once that comment is pushed
There was a problem hiding this comment.
So it seems the updates in #288 actually removed the source of the conflicts so I just pushed an update to reenable this and update the optional dependencies to include it
@jakelorocco if you could take a look?
I also noticed #487 and double checked that my update in 46ccfcc was still necessary (it is)
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
6f3e131
Misc PR
Type of PR
Description
An assortment of test fixes to get
uv run pytestpassing both locally on my Mac and on bluevela.Testing