Closed
Conversation
ker0x
force-pushed
the
feature/types-declaration
branch
from
d2bfcb6 to
bd4eefb
Compare
Member
|
Thanks. Before merging this we should wait for geocoder-php/Geocoder#1184 Just a question about rector: if the code is migrated once, then what's the point of introducing it as dependency? |
Contributor
Author
|
@norkunas It can help with further modernization (symfony migration, code refactoring, etc.). But if you prefer, I can remove it |
Member
|
I understand, but how often it will be needed here? :) I think rector better suits for php projects than libraries. Imho it's easy enough to run once make a PR without including it as a dependency just to be downloaded everytime in CI. |
ker0x
force-pushed
the
feature/types-declaration
branch
from
bd4eefb to
2d26660
Compare
Contributor
Author
|
@norkunas good point. I updated my PR and removed Rector from it 😉 |
ker0x
force-pushed
the
feature/types-declaration
branch
from
2d26660 to
e1c2988
Compare
ker0x
force-pushed
the
feature/types-declaration
branch
from
e1c2988 to
a888538
Compare
norkunas
reviewed
Jan 26, 2024
norkunas
reviewed
Jan 26, 2024
norkunas
reviewed
Jan 26, 2024
norkunas
reviewed
Jan 26, 2024
norkunas
reviewed
Jan 26, 2024
ker0x
force-pushed
the
feature/types-declaration
branch
from
a888538 to
162cb1e
Compare
ker0x
force-pushed
the
feature/types-declaration
branch
from
162cb1e to
6cb8d5c
Compare
Member
|
Thanks @ker0x i am closing this one, as most of the work was done in smaller pr's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add types declaration when possible. It also adds Rector as a dev dependency to facilitate code modernization.