[WIP] Add stacindex.org catalog browsing interface#1062
[WIP] Add stacindex.org catalog browsing interface#1062mfisher87 merged 36 commits intogeojupyter:geojupyter-dse-internsfrom
Conversation
|
Integration tests report: appsharing.space |
mfisher87
left a comment
There was a problem hiding this comment.
It's really cool to see this in action and play with the new functionality! Thanks for your work.
I posted in our intern slack channel about how these comments are organized and guidance for addressing them!
| "lib": ["ES2019", "WebWorker", "DOM"] | ||
| }, | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true |
There was a problem hiding this comment.
Question: Why was this configuration removed? Is removing it necessary for this PR to work?
There was a problem hiding this comment.
We don't recall removing it, and we don't think removing it is necessary for this PR to work.
There was a problem hiding this comment.
We don't recall removing it, and removing it is not necessary for this PR to work.
There was a problem hiding this comment.
OK! In that case, please revert this change :)
| <TabsList className="w-full grid grid-cols-2 mb-2 px-2 mt-2"> | ||
| <TabsTrigger value="filters" className="text-xs"> | ||
| {isGenericMode ? 'Browser' : 'Filters'} | ||
| </TabsTrigger> | ||
| <TabsTrigger value="results" className="text-xs"> | ||
| Results ({activeTotalResults}) | ||
| </TabsTrigger> | ||
| </TabsList> | ||
| <TabsContent | ||
| value="filters" | ||
| className="flex-1 overflow-hidden flex flex-col h-full px-2" | ||
| > |
There was a problem hiding this comment.
Quality: I think we can restore the original styles, classes, and other attributes like defaultValue on these components. I think the removal of the original classes is why the selected tab doesn't have an underline like it does in the currently-released version of JupyterGIS!
There was a problem hiding this comment.
Nice! I want to look on my end to see if the underlining of the selected tab is fixed before marking this resolved.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@mfisher87 Hey Matt, we are done addressing each comment. |
nakul-py
left a comment
There was a problem hiding this comment.
Here are some Ready to commit changes to fix linting issues.
|
Great job with the comments so far. I've left responses for some, and marked the rest resolved. After addressing the responses above, we still need to get all the checks to green ✔️ ! As @nakul-py noted the only failing job is the lint job. Linting ensures that our codebase uses consistent patterns and formatting, and the process is mostly automatic. Please either use the GitHub interface to accept and commit the suggestions from Nakul's review, and/or use the |
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
|
Triggering CI to run Checks again. |
|
@gaolinai8888 As Matt suggests earlier you can also fix the import order lint issues by using the |
| "lib": ["ES2019", "WebWorker", "DOM"] | ||
| }, | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true |
There was a problem hiding this comment.
We don't recall removing it, and we don't think removing it is necessary for this PR to work.
|
@mfisher87 Hey Matt, we successfully completed the lint check and addressed the other comments too. |
|
Thanks! There's still one outstanding comment: https://github.com/geojupyter/jupytergis/pull/1062/files#r2696801641 |
5e14ad7
into
geojupyter:geojupyter-dse-interns
Description
Important
This PR is part of an intern project, and will not be merged in to
main-- there's still some work to do that didn't fit in the time bounds of the internship before we can merge a generic stac catalog interface into themainbranch. We'll merge it in togeojupyter-dse-internsbranch for now!This PR implements the catalog browsing and collection selection workflow for the STAC catalog. It enables users to recursively browse collections and subcollections, view selected collections, and display items within the Results tab using the existing results interface.
What this PR adds:
Retains support for selecting and browsing the Stac catalog using the current UI
Adds recursive collection browsing, allowing deeply nested subcollections
Enables selecting a collection, displaying the selected collection and subcollections, and displaying items from the selected collection in the Results tab
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lintCITATION.cffcontains an author entry for yourself📚 Documentation preview: https://jupytergis--1062.org.readthedocs.build/en/1062/
💡 JupyterLite preview: https://jupytergis--1062.org.readthedocs.build/en/1062/lite