Skip to content

Add symbolologyState to the VectorTileLayer schema#1106

Merged
martinRenou merged 2 commits intogeojupyter:mainfrom
HaudinFlorence:add-symbologyState-to-VectorTileLayer-schema
Feb 6, 2026
Merged

Add symbolologyState to the VectorTileLayer schema#1106
martinRenou merged 2 commits intogeojupyter:mainfrom
HaudinFlorence:add-symbologyState-to-VectorTileLayer-schema

Conversation

@HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Feb 5, 2026

Add symbologyState to the VectorTileLayer schema. Update layer_gallery_generator.py accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Binder 👈 Launch a Binder on branch HaudinFlorence/jupytergis/add-symbologyState-to-VectorTileLayer-schema

@HaudinFlorence HaudinFlorence added the enhancement New feature or request label Feb 5, 2026
@HaudinFlorence HaudinFlorence self-assigned this Feb 5, 2026
@HaudinFlorence HaudinFlorence force-pushed the add-symbologyState-to-VectorTileLayer-schema branch from dc4b783 to d94e02f Compare February 5, 2026 21:17
@HaudinFlorence HaudinFlorence force-pushed the add-symbologyState-to-VectorTileLayer-schema branch from f5c2d44 to 549d7ce Compare February 5, 2026 21:21
@HaudinFlorence HaudinFlorence marked this pull request as ready for review February 5, 2026 21:21
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Integration tests report: appsharing.space

@HaudinFlorence HaudinFlorence force-pushed the add-symbologyState-to-VectorTileLayer-schema branch from f5abeb7 to e3cc098 Compare February 5, 2026 21:27
Update layer_gallery_generator.py accordingly.
@HaudinFlorence HaudinFlorence force-pushed the add-symbologyState-to-VectorTileLayer-schema branch from 3e90500 to 9f7007e Compare February 5, 2026 22:18
"minimum": 0,
"maximum": 1
},
"symbologyState": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future us, it would be great to not have to maintain those duplications

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For clarification, the VectorTileLayer in the gallery was not complete, due to the schema being incomplete as well, resulting in the symbology panel not being responsive.

@martinRenou martinRenou merged commit dcacfd8 into geojupyter:main Feb 6, 2026
15 checks passed
@HaudinFlorence
Copy link
Contributor Author

@martinRenou Thanks for the review

gjmooney pushed a commit to gjmooney/jupytergis that referenced this pull request Feb 18, 2026
* Add symbologyState in the VectorTileLayer schema.
Update layer_gallery_generator.py accordingly.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants