Skip to content

Missed some renames#1108

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
gjmooney:more_story_map_fixes
Feb 10, 2026
Merged

Missed some renames#1108
martinRenou merged 1 commit intogeojupyter:mainfrom
gjmooney:more_story_map_fixes

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Feb 6, 2026

Description

Missed some symbology override -> layer override renames.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint
  • If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

📚 Documentation preview: https://jupytergis--1108.org.readthedocs.build/en/1108/
💡 JupyterLite preview: https://jupytergis--1108.org.readthedocs.build/en/1108/lite

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/more_story_map_fixes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Integration tests report: appsharing.space

@gjmooney gjmooney added the bug Something isn't working label Feb 6, 2026
Copy link
Collaborator

@nakul-py nakul-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg!
Just a question below.

disabled={!canOpenSymbology}
>
<span className="fa fa-brush" style={{ marginRight: '4px' }} />
Edit Symbology
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be renamed to layer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that button is for opening the symbology panel

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit b40f36c into geojupyter:main Feb 10, 2026
17 of 18 checks passed
@gjmooney gjmooney deleted the more_story_map_fixes branch February 10, 2026 09:40
gjmooney added a commit to gjmooney/jupytergis that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants