UI related bug fixes and examples update#1110
Merged
martinRenou merged 26 commits intogeojupyter:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
martinRenou
reviewed
Feb 10, 2026
| "type": "string", | ||
| "description": "The id of the source" | ||
| "description": "The id of the source", | ||
| "default": "" |
Member
There was a problem hiding this comment.
Do we really need this default for source ids? "" is not a valid value
gjmooney
force-pushed
the
example-fix
branch
from
d90f118 to
6e0956c
Compare
Collaborator
Author
|
please update snapshots |
gjmooney
changed the title
Collaborator
Author
|
please update snapshots |
mfisher87
changed the title
martinRenou
approved these changes
Feb 11, 2026
| python/jupytergis_lite/dist/jupytergis* | ||
| if-no-files-found: error | ||
|
|
||
| validate-examples: |
martinRenou
reviewed
Feb 12, 2026
martinRenou
force-pushed
the
example-fix
branch
from
7829a2f to
3955a27
Compare
martinRenou
force-pushed
the
example-fix
branch
from
3955a27 to
b38f1e4
Compare
gjmooney
added a commit
to gjmooney/jupytergis
that referenced
this pull request
Feb 18, 2026
* Add empty string as path when creating gejson via python * Fill blanks with defaults * Save defaults when loading from python * Use defaults when creating layer in python * Add default values to layer properties * Add defaults to sources * Random lint * Remove default empty string for source IDs * Add defaults to fix test * And anotha one * Touch all the examples * Use enum member as default when generating types * Clean up examples * Save method * Fix vector layer schema * Remove old type stuff * Add example validation to CI workflow * Attempt * Lint * Attempt * Attempt * Update Playwright Snapshots * Update Playwright Snapshots * Fix heatmap creation * Update Playwright Snapshots * Apply suggestion from @martinRenou --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: martinRenou <martin.renou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix bug with extra warning in the object properties panel when creating layers via Python API by using schema defaults for unspecified fields instead of
NoneI also went through all the examples and updated them to reflect the current schema. I added a script to the CI workflow to ensure the examples match the schema as well.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lintCITATION.cffcontains an author entry for yourself