Skip to content

Enable manually running the build workflow#1122

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
nakul-py:ci-restart
Feb 18, 2026
Merged

Enable manually running the build workflow#1122
martinRenou merged 1 commit intogeojupyter:mainfrom
nakul-py:ci-restart

Conversation

@nakul-py
Copy link
Collaborator

@nakul-py nakul-py commented Feb 15, 2026

Description

This PR adds Run Workflow button in Actions tab

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint
  • If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

📚 Documentation preview: https://jupytergis--1122.org.readthedocs.build/en/1122/
💡 JupyterLite preview: https://jupytergis--1122.org.readthedocs.build/en/1122/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch nakul-py/jupytergis/ci-restart

@nakul-py nakul-py added the maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc. label Feb 15, 2026
@nakul-py nakul-py marked this pull request as draft February 15, 2026 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

Integration tests report: appsharing.space

@nakul-py nakul-py marked this pull request as ready for review February 15, 2026 09:42
@nakul-py nakul-py changed the title Restart CI via comment. Adding Run Workflow button Feb 15, 2026
@mfisher87 mfisher87 changed the title Adding Run Workflow button Enable manually running the build workflow Feb 15, 2026
@mfisher87
Copy link
Member

mfisher87 commented Feb 15, 2026

Heya @nakul-py thanks for the PR! Could you share the use case of this change? Running workflows with workflow_dispatch requires "write" permissions, but you currently have "triage". I'm OK with granting "write" permissions, but we should chat with the rest of the team first!

@nakul-py
Copy link
Collaborator Author

Running workflows with workflow_dispatch requires "write" permissions, but you currently have "triage".

Ohh, I am not aware of this i think any contributor can run workflow 😅.

Could you share the use case of this change?

I want to get rid of PR closing and reopening every time to trigger ci so i think adding the button would be worth for contributors to run ci again but as you told earlier only the person who have write permissions have to run workflow again.

So i am wondering if we have another solution. I think the next option could be add a yaml file that runs ci again with comment like we do to update snapshots.

@mfisher87
Copy link
Member

Is this for cases where you want to rerun a test because you think it might be flaky?

@nakul-py
Copy link
Collaborator Author

Is this for cases where you want to rerun a test because you think it might be flaky?

Yes, as you can see in #1121 the check links test fails two times and passes on third time.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a fine change even if not everybody can trigger it 👍🏽

@martinRenou martinRenou merged commit c0fb2b9 into geojupyter:main Feb 18, 2026
17 checks passed
@nakul-py nakul-py deleted the ci-restart branch February 18, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants