Focusing Layer/Group always to rename#1123
Conversation
|
Integration tests report: appsharing.space |
packages/base/src/keybindings.json
Outdated
There was a problem hiding this comment.
Maybe that one is missing it as well?
There was a problem hiding this comment.
If i add same class here then both rename layer or group have same selector and than only one command works because of this
jupytergis/packages/base/src/commands/index.ts
Lines 1265 to 1270 in 0863353
There was a problem hiding this comment.
To omit this situation we are using new single renameSelected command that helps F2 works consistently for both layers and groups and behavior is selection driven.
|
Hey @martinRenou if this approach was correct we can also done same refactor for remove layer/group commands too. |
We should be extra careful that the logic still works with layers/layer groups/story segments. I'm 👍🏽 on unifying the logic and simplifying the keybindings definition. |
Yes, I have updated the screen cast in PR description which shows logic works fine. |

Description
This PR fixes Renaming a layer with F2 doesn't work unless you've just clicked the layer.
Now we can easily rename a layer without clicking evevrytime.
Screencast.From.2026-02-16.21-08-34.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--1123.org.readthedocs.build/en/1123/
💡 JupyterLite preview: https://jupytergis--1123.org.readthedocs.build/en/1123/lite