Skip to content

Scrollytelling fix#1128

Merged
martinRenou merged 22 commits intogeojupyter:mainfrom
gjmooney:scrollytelling-fix
Feb 18, 2026
Merged

Scrollytelling fix#1128
martinRenou merged 22 commits intogeojupyter:mainfrom
gjmooney:scrollytelling-fix

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Feb 17, 2026

Description

This fixes the janky scrolling some people were experiencing using story maps in Specta. Segments were skipped sometimes, or one scroll would cause multiple segment changes.

I think the scroll issues were caused by scroll position being computed from stale layout during segment transitions, especially when repaints were slow. This PR adds a callback from StoryViewerPanel to MainView that runs when segment transition animations finish, and blocks further scroll-driven segment changes until then.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint
  • If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

📚 Documentation preview: https://jupytergis--1128.org.readthedocs.build/en/1128/
💡 JupyterLite preview: https://jupytergis--1128.org.readthedocs.build/en/1128/lite

@gjmooney gjmooney added the bug Something isn't working label Feb 17, 2026
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/scrollytelling-fix

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Integration tests report: appsharing.space

@gjmooney gjmooney marked this pull request as ready for review February 18, 2026 11:29
@gjmooney gjmooney requested a review from martinRenou February 18, 2026 11:29
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit ea4b1af into geojupyter:main Feb 18, 2026
16 checks passed
@gjmooney gjmooney deleted the scrollytelling-fix branch February 24, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants