Merged
Conversation
Contributor
Contributor
|
Integration tests report: appsharing.space |
e477668 to
1b3dd74
Compare
1b3dd74 to
e2cec05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the janky scrolling some people were experiencing using story maps in Specta. Segments were skipped sometimes, or one scroll would cause multiple segment changes.
I think the scroll issues were caused by scroll position being computed from stale layout during segment transitions, especially when repaints were slow. This PR adds a callback from
StoryViewerPaneltoMainViewthat runs when segment transition animations finish, and blocks further scroll-driven segment changes until then.Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lintCITATION.cffcontains an author entry for yourself📚 Documentation preview: https://jupytergis--1128.org.readthedocs.build/en/1128/
💡 JupyterLite preview: https://jupytergis--1128.org.readthedocs.build/en/1128/lite