Skip to content

Try fixing jupyterlite deployment#332

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
arjxn-py:fix-lite
Jan 14, 2025
Merged

Try fixing jupyterlite deployment#332
martinRenou merged 1 commit intogeojupyter:mainfrom
arjxn-py:fix-lite

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Jan 14, 2025

Description

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--332.org.readthedocs.build/en/332/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/fix-lite

@martinRenou martinRenou added the bug Something isn't working label Jan 14, 2025
@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

@martinRenou
Copy link
Member

The lite link is not generated since we moved to readthedocs. We have no way to test it but merge it. Let's trust it works

@martinRenou martinRenou merged commit fdf823c into geojupyter:main Jan 14, 2025
14 of 15 checks passed
@arjxn-py
Copy link
Member Author

Doesn't seem to be fixed, still the same error 😕

@mfisher87
Copy link
Member

We have no way to test it but merge it. Let's trust it works

@martinRenou @arjxn-py You can click the link added to the PR description or click the ReadTheDocs entry in the checks tab for a preview.

image

@martinRenou
Copy link
Member

Thanks for commenting, yes I was wrong on this. I assumed it was not installed because it was not there in the UI, it was simply broken :D

@arjxn-py arjxn-py deleted the fix-lite branch January 20, 2025 10:46
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants