Register new projections if needed when adding layers#343
Merged
martinRenou merged 4 commits intogeojupyter:mainfrom Jan 16, 2025
Merged
Register new projections if needed when adding layers#343martinRenou merged 4 commits intogeojupyter:mainfrom
martinRenou merged 4 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* save * Wait for layers to be ready and add projections as needed * Use set to track loading layers * Better error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #326
This checks that the projection for a new layer is already registered with OpenLayers, and if not it registers the projection using definitions from
Proj4ListChecklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--343.org.readthedocs.build/en/343/
💡 JupyterLite preview is available from the doc, by clicking on