Skip to content

Fix JupyterGISDoc.setSource#346

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
davidbrochart:fix-setsource
Jan 16, 2025
Merged

Fix JupyterGISDoc.setSource#346
martinRenou merged 1 commit intogeojupyter:mainfrom
davidbrochart:fix-setsource

Conversation

@davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Jan 16, 2025

Description

The source can be set from a JSON or a string value, according to jupyter-ydoc's API.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--346.org.readthedocs.build/en/346/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupytergis/fix-setsource

@davidbrochart davidbrochart added the bug Something isn't working label Jan 16, 2025
@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 4f9198c into geojupyter:main Jan 16, 2025
19 checks passed
@davidbrochart davidbrochart deleted the fix-setsource branch January 16, 2025 13:13
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants