Move jupyter-collaboration dependency to jupytergis#347
Move jupyter-collaboration dependency to jupytergis#347martinRenou merged 5 commits intogeojupyter:mainfrom
Conversation
|
|
|
Integration tests report: appsharing.space |
| ] | ||
| dependencies = [ | ||
| "jupyter-ydoc>=2,<3", | ||
| "jupyter-collaboration>=3,<4", |
There was a problem hiding this comment.
Should we use extras instead?
Technically, this break jupytergis-core, right?
There was a problem hiding this comment.
Technically, this break jupytergis-core, right?
Does jupytergis-core use jupyter-collaboration specifically?
There was a problem hiding this comment.
Yes, it provides the labextension for opening JupyterGIS files in JupyterLab
There was a problem hiding this comment.
But it just needs an ICollaborativeDrive, right?
There was a problem hiding this comment.
Then someone needs to provide it. If we remove the jupyter-collaboration dep from jupytergis-core, nobody provides collaboration support when we just do:
pip install jupytergis-core
There was a problem hiding this comment.
That is the goal of this PR, so that someone can provide their own collaboration system (other than jupyter-collaboration).
Since the jupyter-collaboration was moved to jupytergis you still get it on a default installation.
There was a problem hiding this comment.
Ok. Yeah I guess it's not possible to do that using extras...
* Move jupyter-collaboration dependency to jupytergis * Install jupyter-collaboration in tests * And in build requirements * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2 participants
Description
Closes #338.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--347.org.readthedocs.build/en/347/
💡 JupyterLite preview is available from the doc, by clicking on