Fix Lite Deployment Badge via RTD on PR using Custom Action#356
Merged
martinRenou merged 2 commits intogeojupyter:mainfrom Jan 17, 2025
Merged
Fix Lite Deployment Badge via RTD on PR using Custom Action#356martinRenou merged 2 commits intogeojupyter:mainfrom
martinRenou merged 2 commits intogeojupyter:mainfrom
Conversation
--------- Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
Member
|
Lots of fun working with you this morning/evening ;) Thanks for your patience with me missing the obvious 🤣 Upstream PR: readthedocs/actions#48 |
mfisher87
reviewed
Jan 17, 2025
Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
…er#356) * Fix Lite Deployment Badge via RTF on PR --------- Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com> * Simplify comment Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com> --------- Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com> Co-authored-by: martinRenou <martin.renou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the lite badge on PR which now correctly redirects to Read the Docs lite deployment.
This was a nasty one!
All thanks to @mfisher87 for patching the GH action on his fork that we've been using 🚀
It has been tested on this PR on my fork
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--356.org.readthedocs.build/en/356/
💡 JupyterLite preview is available from the doc, by clicking on