Merged
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
gjmooney
force-pushed
the
multi_band_symbology
branch
from
f0d9fc4 to
11631bd
Compare
martinRenou
reviewed
Jan 21, 2025
| colorExpr.push(bandValue !== 0 ? ['band', bandValue] : 0); | ||
| }); | ||
|
|
||
| // Array expression expects 4 values |
Member
There was a problem hiding this comment.
Is it for the alpha channel? Should we expose that in the UI too? e.g. allow using the first band for alpha channel
Collaborator
Author
There was a problem hiding this comment.
QGIS only has options to set the red, green, and blue bands. I think this is a good place to start and we can add an option to change the alpha in a future PR.
gjmooney
force-pushed
the
multi_band_symbology
branch
from
16fb378 to
3081abc
Compare
martinRenou
approved these changes
Jan 21, 2025
Member
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks!!
Let's track the alpha channel thingy in an issue
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* Add label prop to BandRow * Add multiband to tiff rendering * Hide min/max for multiband * Load renderType from params * Add multiband fields to webgllayer schema * Add multiband color symbology panel * Condense * Iterate * Factor out common stuff to hook * Clean up * Use correct alpha band
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Multiband symbology #328
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--360.org.readthedocs.build/en/360/
💡 JupyterLite preview: https://jupytergis--360.org.readthedocs.build/en/360/lite