Skip to content

Add a pretty JupyterLite button to docs#361

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
mfisher87:jupyterlite-pretty-button
Jan 18, 2025
Merged

Add a pretty JupyterLite button to docs#361
martinRenou merged 1 commit intogeojupyter:mainfrom
mfisher87:jupyterlite-pretty-button

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Jan 18, 2025

Description

Recording 2025-01-17 at 18 23 18

I knew I had seen this somewhere! Someone amazing found it :) https://jupyter.zulipchat.com/#narrow/channel/474838-jupyterlite/topic/Beautiful.20.22Try.20JupyterLite.22.20button/near/494275235

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--361.org.readthedocs.build/en/361/
💡 JupyterLite preview: https://jupytergis--361.org.readthedocs.build/en/361/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/jupyterlite-pretty-button

@mfisher87 mfisher87 added the documentation Improvements or additions to documentation label Jan 18, 2025
@mfisher87 mfisher87 force-pushed the jupyterlite-pretty-button branch from a434e26 to 96018a2 Compare January 18, 2025 01:26
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025

Integration tests report: appsharing.space

@mfisher87 mfisher87 force-pushed the jupyterlite-pretty-button branch from 96018a2 to dd5febd Compare January 18, 2025 01:36
@mfisher87 mfisher87 force-pushed the jupyterlite-pretty-button branch from dd5febd to fb8954f Compare January 18, 2025 01:40
@mfisher87
Copy link
Member Author

I love the yellow and black combination :) 🐝

@mfisher87 mfisher87 marked this pull request as ready for review January 18, 2025 01:47
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Looks neat

@martinRenou martinRenou merged commit 60809d7 into geojupyter:main Jan 18, 2025
14 checks passed
@agriyakhetarpal
Copy link

I think it also makes sense for us to make the hover effect something else, right? Not only does the current change from black text to white text feel too abrupt, the white text also breaks a11y: https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=F7DC1F 🙈

I opine that an apt effect could be to either transform(1.05) the button, or perhaps make it glow at the borders.

I've noticed the problem on the jupyterlite-sphinx side before, but haven't got around to fixing it!

@mfisher87
Copy link
Member Author

mfisher87 commented Jan 22, 2025

Great point, thank you for thinking of accessibility! Would you suggest just leaving the text as black on hover? There's already a slight yello glow effect on the button when hovering, and I think slightly scaling the button up on hover would also look nice. The white/yellow colorscheme really contributes to the "light bulb feel" (I think the abruptness of the hover effect also contributes to that); maybe putting a white glow on the black text would achieve the same while also maintaining high contrast?

@mfisher87 mfisher87 deleted the jupyterlite-pretty-button branch January 22, 2025 16:17
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants