Add a pretty JupyterLite button to docs#361
Conversation
a434e26 to
96018a2
Compare
|
Integration tests report: appsharing.space |
96018a2 to
dd5febd
Compare
dd5febd to
fb8954f
Compare
|
I love the yellow and black combination :) 🐝 |
|
I think it also makes sense for us to make the hover effect something else, right? Not only does the current change from black text to white text feel too abrupt, the white text also breaks a11y: https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=F7DC1F 🙈 I opine that an apt effect could be to either I've noticed the problem on the |
|
Great point, thank you for thinking of accessibility! Would you suggest just leaving the text as black on hover? There's already a slight yello glow effect on the button when hovering, and I think slightly scaling the button up on hover would also look nice. The white/yellow colorscheme really contributes to the "light bulb feel" (I think the abruptness of the hover effect also contributes to that); maybe putting a white glow on the black text would achieve the same while also maintaining high contrast? |
Description
I knew I had seen this somewhere! Someone amazing found it :) https://jupyter.zulipchat.com/#narrow/channel/474838-jupyterlite/topic/Beautiful.20.22Try.20JupyterLite.22.20button/near/494275235
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--361.org.readthedocs.build/en/361/
💡 JupyterLite preview: https://jupytergis--361.org.readthedocs.build/en/361/lite