Add Path Validation for ShapefileSource and ImageSource.#362
Merged
martinRenou merged 6 commits intogeojupyter:mainfrom Jan 20, 2025
Merged
Add Path Validation for ShapefileSource and ImageSource.#362martinRenou merged 6 commits intogeojupyter:mainfrom
ShapefileSource and ImageSource.#362martinRenou merged 6 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
martinRenou
reviewed
Jan 20, 2025
Member
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Neat! I have a tiny question
martinRenou
reviewed
Jan 20, 2025
arjxn-py
added a commit
to arjxn-py/jupytergis
that referenced
this pull request
Jan 21, 2025
martinRenou
added a commit
that referenced
this pull request
Jan 23, 2025
* Caching extended for imageSource * Make caching work for shapefiles * Works for geojson too * use abstracted methods for geotiff too * lint * merge image path validation logic from #362 * don't use caching logic on image * lint * refactor to straightup cache geojson * Remove wrappers, cache any file type * Update packages/base/src/tools.ts Co-authored-by: martinRenou <martin.renou@gmail.com> * lint --------- Co-authored-by: martinRenou <martin.renou@gmail.com>
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
…ter#362) * path validation for shapefile and image. * make geojson inherit from pathbasedform * lint * lint check * add sourceType property to BaseForm.
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* Caching extended for imageSource * Make caching work for shapefiles * Works for geojson too * use abstracted methods for geotiff too * lint * merge image path validation logic from geojupyter#362 * don't use caching logic on image * lint * refactor to straightup cache geojson * Remove wrappers, cache any file type * Update packages/base/src/tools.ts Co-authored-by: martinRenou <martin.renou@gmail.com> * lint --------- Co-authored-by: martinRenou <martin.renou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #357.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--362.org.readthedocs.build/en/362/
💡 JupyterLite preview: https://jupytergis--362.org.readthedocs.build/en/362/lite