Skip to content

Support path lib objects#378

Merged
martinRenou merged 2 commits intogeojupyter:mainfrom
gjmooney:support_path_objects
Jan 22, 2025
Merged

Support path lib objects#378
martinRenou merged 2 commits intogeojupyter:mainfrom
gjmooney:support_path_objects

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jan 21, 2025

Description

#314

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--378.org.readthedocs.build/en/378/
💡 JupyterLite preview: https://jupytergis--378.org.readthedocs.build/en/378/lite

@gjmooney gjmooney added bug Something isn't working enhancement New feature or request labels Jan 21, 2025
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/support_path_objects

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are other places where a path is being manipulated (local JSON, export qgis etc.) and we could handle Path objects too, would you like to update those too?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Integration tests report: appsharing.space

@gjmooney gjmooney force-pushed the support_path_objects branch from 041c85d to 157544e Compare January 21, 2025 15:57
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@martinRenou martinRenou merged commit 6b21a64 into geojupyter:main Jan 22, 2025
13 of 14 checks passed
@gjmooney gjmooney deleted the support_path_objects branch January 30, 2025 12:06
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Support path lib objects

* Iterate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants