Skip to content

Add optional-chaining check for symbologyState#383

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
Meriem-BenIsmail:symbology-error
Jan 22, 2025
Merged

Add optional-chaining check for symbologyState#383
martinRenou merged 1 commit intogeojupyter:mainfrom
Meriem-BenIsmail:symbology-error

Conversation

@Meriem-BenIsmail
Copy link
Member

@Meriem-BenIsmail Meriem-BenIsmail commented Jan 22, 2025

Description

Fixes this error.

image

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--383.org.readthedocs.build/en/383/
💡 JupyterLite preview: https://jupytergis--383.org.readthedocs.build/en/383/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch Meriem-BenIsmail/jupytergis/symbology-error

@arjxn-py arjxn-py added the bug Something isn't working label Jan 22, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

@martinRenou martinRenou merged commit e604142 into geojupyter:main Jan 22, 2025
16 of 17 checks passed
@mfisher87 mfisher87 changed the title Add check for symbologyState Add optional-chaining check for symbologyState Jan 22, 2025
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants