Conversation
|
|
|
In QGIS, heatmaps are a rendering option for vector data. What do you think of implementing it that way in JGIS? That way, the user could switch the same data layer between heatmap, point clustering, and simple rules, for example. The rendering mode abstraction could be applied for other cases as well. Hillshade is a rendering option for single band raster data in QGIS. |
Yea, we should be able to implement that, we'll need to delete and recreate the layer when switching it to a heatmap or vice-versa so we may as well keep the option of adding a heatmap layer directly as well. |
|
Integration tests report: appsharing.space |
gjmooney
force-pushed
the
heatmap_layer
branch
from
b6ea606 to
06cca6e
Compare
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks a lot @gjmooney ! That looks neat.
- Would you be able to add a test cell in the Notebook that makes sure the Python API does work on the long run?
- I guess we need to allow import/export of QGIS heatmap layers? Did you match the schema to something relatable of the QGIS format? If so, we can merge and tackle import/export in a separate PR
| createLayer: true, | ||
| createSource: false, | ||
| layerData: { name: 'Custom Heatmap Layer' }, | ||
| sourceType: 'GeoJSONSource', |
There was a problem hiding this comment.
Is it the only possible source type?
I'm only asking because I'm curious, allowing the form to create multiple source types is another task on itself (also not sure we want to allow it)
There was a problem hiding this comment.
Is it the only possible source type?
I think it should work with any vector source that uses points.
👍
QGIS uses a Heatmap renderer on vector layers, which we currently don't export (@arjxn-py is working on that in #390). For importing form QGIS, it looks like the only attribute OL has that QGIS doesn't is |
gjmooney
force-pushed
the
heatmap_layer
branch
from
2045d42 to
9290eac
Compare
|
please update snapshots |
* Start adding heatmap layer * Add heatmap to layer context menu * Get features into dropdown on form * Clean up * Add color to schema * Add heatmap symbology panel * Layer form something * Add symbology state * Iterate * Clean up * Refactor _onLayersChanged * Implement layer type changing * Set type in symbology * IDK what rjsf wants anymore * Recreate layer when changing feature * Add blur and radius to symbology * Update color ramp css * Remove blur and radius from form * Capitalize form labels * Remove icon and fix label * Clean up * Choose defaults betters * Add notebook api for heatmap * Add heatmaps to Notebook test * Update Playwright Snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 participants
Description
Adds heatmap layers
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--384.org.readthedocs.build/en/384/
💡 JupyterLite preview: https://jupytergis--384.org.readthedocs.build/en/384/lite