Skip to content

Add local file support for GeoTiff#385

Merged
martinRenou merged 5 commits intogeojupyter:mainfrom
Meriem-BenIsmail:geotiff-localfile
Jan 24, 2025
Merged

Add local file support for GeoTiff#385
martinRenou merged 5 commits intogeojupyter:mainfrom
Meriem-BenIsmail:geotiff-localfile

Conversation

@Meriem-BenIsmail
Copy link
Member

@Meriem-BenIsmail Meriem-BenIsmail commented Jan 23, 2025

@Meriem-BenIsmail Meriem-BenIsmail added the enhancement New feature or request label Jan 23, 2025
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch Meriem-BenIsmail/jupytergis/geotiff-localfile

@Meriem-BenIsmail
Copy link
Member Author

We could hold off on this PR until #339 is merged maybe so we wouldn't have conflicts with the caching in tools.ts.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Integration tests report: appsharing.space

local geotiff file support + caching added.

filewidget added.

fixed validation for urls.

mimetype check for geotiff

lint

loadfile method added for smbology.

lint
@Meriem-BenIsmail Meriem-BenIsmail marked this pull request as ready for review January 23, 2025 11:28
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Would you be able to add ../examples/*.tif here https://github.com/geojupyter/jupytergis/blob/main/docs/conf.py#L35 so the new file get included in the lite deployment?

@martinRenou
Copy link
Member

I've been having a try with the JupyterLite deployment. The added filebrowser works well!

  • the filedialog is very narrow and should probably take much more space.
  • we don't get anything on the screen for almost 20 seconds, even the loading indicator in the toolbar is not showing up yet. Maybe it's something to be fixed in another PR, let's track this in an issue.
Screencast.From.2025-01-23.17-07-21.mp4

@Meriem-BenIsmail
Copy link
Member Author

I've been having a try with the JupyterLite deployment. The added filebrowser works well!

  • the filedialog is very narrow and should probably take much more space.
  • we don't get anything on the screen for almost 20 seconds, even the loading indicator in the toolbar is not showing up yet. Maybe it's something to be fixed in another PR, let's track this in an issue.

Screencast.From.2025-01-23.17-07-21.mp4

About the 20s delay, it takes some time for the geotiff file to be read and loaded that's why, so maybe we can try to show the loading indicator as soon as the file is opened. I can try to do it in this PR or maybe a separate one is better.

@Meriem-BenIsmail
Copy link
Member Author

On another note I think I could fix it in this PR so I'll do that.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's track my concerns in issues after merging

@martinRenou martinRenou merged commit 98ef6b6 into geojupyter:main Jan 24, 2025
14 checks passed
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* local file geotiff

local geotiff file support + caching added.

filewidget added.

fixed validation for urls.

mimetype check for geotiff

lint

loadfile method added for smbology.

lint

* mimetype

* make loadGeotiff generic

* add example geotiff file to conf.py

* avoid loading the file when validating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local GeoTIFF file support

2 participants