Merged
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
Meriem-BenIsmail
force-pushed
the
error-handling
branch
from
fdd8d11 to
f37695e
Compare
martinRenou
reviewed
Jan 29, 2025
Meriem-BenIsmail
force-pushed
the
error-handling
branch
3 times, most recently
from
451a03b to
7fcc020
Compare
Member
|
@Meriem-BenIsmail if you rebase your PR, the CI should be green 🤞🏽 |
martinRenou
requested changes
Jan 30, 2025
Member
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Neat! I have a couple of suggestions
Meriem-BenIsmail
force-pushed
the
error-handling
branch
from
83118d3 to
461d402
Compare
Member
|
Triggering a rebuild with new readthedocs configuration, some readthedocs plugin seems to go in my way for testing the Lite deployment |
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* added error handling * modify error msg. * store invalid layers+errors * include error message in the dialog. * compare error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #327.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--391.org.readthedocs.build/en/391/
💡 JupyterLite preview: https://jupytergis--391.org.readthedocs.build/en/391/lite