Merged
Conversation
Contributor
martinRenou
approved these changes
Jan 29, 2025
Member
martinRenou
left a comment
There was a problem hiding this comment.
Thanks! Don't we need to provide an implementation for those? Or it's already there?
Contributor
|
Integration tests report: appsharing.space |
Collaborator
Author
|
It's already there, it has been added when upgrading jupyter-collaboration to v3 #204 Don't really know why it did not fail from the beginning. |
Collaborator
Collaborator
Author
Collaborator
|
I don't think we should look at code and try to guess if major versions are compatible, this is very error prone. |
4 tasks
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should fix #404
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--406.org.readthedocs.build/en/406/
💡 JupyterLite preview: https://jupytergis--406.org.readthedocs.build/en/406/lite