Skip to content

Fix shared document interface#406

Merged
brichet merged 1 commit intogeojupyter:mainfrom
brichet:fix_build_prod
Jan 29, 2025
Merged

Fix shared document interface#406
brichet merged 1 commit intogeojupyter:mainfrom
brichet:fix_build_prod

Conversation

@brichet
Copy link
Collaborator

@brichet brichet commented Jan 29, 2025

Description

Should fix #404

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--406.org.readthedocs.build/en/406/
💡 JupyterLite preview: https://jupytergis--406.org.readthedocs.build/en/406/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupytergis/fix_build_prod

@brichet brichet added the maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc. label Jan 29, 2025
@brichet brichet marked this pull request as ready for review January 29, 2025 09:13
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't we need to provide an implementation for those? Or it's already there?

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

@brichet
Copy link
Collaborator Author

brichet commented Jan 29, 2025

It's already there, it has been added when upgrading jupyter-collaboration to v3 #204

Don't really know why it did not fail from the beginning.

@brichet brichet merged commit b5fb974 into geojupyter:main Jan 29, 2025
16 of 18 checks passed
@brichet brichet deleted the fix_build_prod branch January 29, 2025 10:47
@davidbrochart
Copy link
Collaborator

jupyter-ydoc is pinned to >=2,<3 here, but @jupyter/ydoc v3 is allowed here. Isn't that a problem?

@brichet
Copy link
Collaborator Author

brichet commented Jan 29, 2025

jupyter-ydoc is pinned to >=2,<3 here, but @jupyter/ydoc v3 is allowed here. Isn't that a problem?

We should update it, but I don't think there are breaking change on the python package between v2 and v3. It doesn't seems to be an problem.

@davidbrochart
Copy link
Collaborator

I don't think we should look at code and try to guess if major versions are compatible, this is very error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to release

3 participants