Skip to content

Rework add layer toolbar menu#410

Merged
martinRenou merged 3 commits intogeojupyter:mainfrom
gjmooney:redo_toolbar_add_layer
Jan 30, 2025
Merged

Rework add layer toolbar menu#410
martinRenou merged 3 commits intogeojupyter:mainfrom
gjmooney:redo_toolbar_add_layer

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jan 29, 2025

Description

Resolves #403

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--410.org.readthedocs.build/en/410/
💡 JupyterLite preview: https://jupytergis--410.org.readthedocs.build/en/410/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/redo_toolbar_add_layer

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Integration tests report: appsharing.space

@gjmooney gjmooney force-pushed the redo_toolbar_add_layer branch from fb17fa2 to 44ba4ca Compare January 30, 2025 10:57
@gjmooney gjmooney added the enhancement New feature or request label Jan 30, 2025
@gjmooney gjmooney marked this pull request as ready for review January 30, 2025 11:43
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@martinRenou martinRenou merged commit 1a7dc99 into geojupyter:main Jan 30, 2025
14 checks passed
@gjmooney gjmooney deleted the redo_toolbar_add_layer branch January 30, 2025 16:15
@mfisher87
Copy link
Member

Nice!!

HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Rework add layer toolbar menu

* Use MenuSvg

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the add layer menu, group the options more logically

3 participants