Skip to content

Import VectorLayer from QGIS#424

Merged
martinRenou merged 20 commits intogeojupyter:mainfrom
arjxn-py:qgis-vectorlayer-import
Feb 5, 2025
Merged

Import VectorLayer from QGIS#424
martinRenou merged 20 commits intogeojupyter:mainfrom
arjxn-py:qgis-vectorlayer-import

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 3, 2025

Description

image image image

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--424.org.readthedocs.build/en/424/
💡 JupyterLite preview: https://jupytergis--424.org.readthedocs.build/en/424/lite

@arjxn-py arjxn-py marked this pull request as draft February 3, 2025 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/qgis-vectorlayer-import

@martinRenou martinRenou added the enhancement New feature or request label Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py marked this pull request as ready for review February 4, 2025 14:02
@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 4, 2025

This is ready for interim reviews, I'm now adding tests

@arjxn-py arjxn-py force-pushed the qgis-vectorlayer-import branch from 31e0eca to fdc157c Compare February 4, 2025 14:49
@arjxn-py arjxn-py changed the title [WIP]: Import VectorLayer from QGIS Import VectorLayer from QGIS Feb 5, 2025
Copy link
Collaborator

@gjmooney gjmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Everything works well.

@martinRenou
Copy link
Member

Let's wait for #440 to be in, I want to make sure the remaining CI failures are not related to this particular PR

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Still investigating the RTD failure

@martinRenou martinRenou merged commit e209b77 into geojupyter:main Feb 5, 2025
13 of 14 checks passed
@arjxn-py arjxn-py deleted the qgis-vectorlayer-import branch March 16, 2025 13:06
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* categorised symbology

* a little handling for radius

* categorised symbology works nicely

* phewww

* single symbol fill

* fix for line

* Make graduated work

* clean up

* graduated works

* add test for fill graduated

* fix

* remove some non supported options

* fix range in graduated symbology

* fix test

* Add test for categorised rendering on line

* fix test

* try fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants