-
Notifications
You must be signed in to change notification settings - Fork 69
Re-organize docs navigation and add releasing guide #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be05b84
Move contributing docs into a directory
mfisher87 279424e
Remove project name from changelog doc title
mfisher87 3a0918e
Rearrange docs into "Contributing guide" and "User guide"
mfisher87 68462e2
Add releasing doc
mfisher87 189883b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 81cb6c3
Fixup asset links in tutorial
mfisher87 0be2180
Tabs to spaces :bell:
mfisher87 3d067e7
Replace absolute links with relative links
mfisher87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # JupyterGIS Changelog | ||
| # Changelog | ||
|
|
||
| <!-- <START NEW CHANGELOG ENTRY> --> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ============ | ||
| Code quality | ||
| ============ | ||
|
|
||
| We have several tools configured for checking code quality: | ||
|
|
||
| * Pre-commit checks run automatically at commit time. | ||
| Install checks with ``pre-commit install``. | ||
| Run them manually with ``pre-commit run --all-files``. | ||
| **Will exit non-zero when finding errors or changing files.** | ||
|
|
||
| * Ruff formats and lints (sometimes autofixes) Python code. | ||
|
|
||
| * Generic pre-commit checks help avoid common mistakes like committing large | ||
| files or trailing whitespace. | ||
|
|
||
| * Package scripts (defined in ``package.json``) to check (and/or fix) | ||
| TypeScript, JavaScript, CSS, JSON, Markdown, and YAML. | ||
| Run manually with ``jlpm run lint``. | ||
| **Will exit 0 when applying fixes. | ||
| Check the logs and/or ``git status`` after every run.** | ||
|
|
||
| * Prettier formats the file types listed above. | ||
|
|
||
| * Eslint lints (sometimes autofixes) JS/TS code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Contributor guide | ||
|
|
||
| We're thrilled you're ready to contribute to JupyterGIS! | ||
|
|
||
| To chat with other contributors, please | ||
| [join us on Zulip](https://jupyter.zulipchat.com/#narrow/channel/471314-geojupyter)! | ||
|
|
||
| ```{toctree} | ||
| :maxdepth: 2 | ||
|
|
||
| development_setup | ||
| code_quality | ||
| releasing | ||
| troubleshooting | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Releasing | ||
|
|
||
| ## Automated Releases with `jupyter_releaser` | ||
|
|
||
| The recommended way to make a release is to use | ||
| [`jupyter_releaser`](https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_release_from_repo.html) | ||
| in GitHub Actions. | ||
| Follow the linked instructions. | ||
|
|
||
| **This project uses [Semantic Versioning](https://semver.org)**. | ||
|
|
||
| :::{important} | ||
| Because this project is in early development, we **do not bump the major version number**. | ||
| Most changes are minor version bumps, even breaking changes. | ||
| See [the SemVer FAQ](https://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase) for more. | ||
| ::: | ||
|
|
||
| ### Specifying a version spec | ||
|
|
||
| When prompted for a "New Version Specifier", the default value is `next`. | ||
| This will bump the packages as follows: | ||
|
|
||
| - `0.1.0a0` -> `0.1.0a1` | ||
| - `0.1.0b7` -> `0.1.0b8` | ||
| - `0.1.0` -> `0.1.1` | ||
|
|
||
| This is often **not** what we want. | ||
| To bump to another version, you can specify the Python version directly. | ||
| For example: | ||
|
|
||
| - `0.1.0b8` | ||
| - `0.4.0` | ||
| - `1.0.0` | ||
| - `1.2.0rc0` | ||
|
|
||
| You can also specify a version part, e.g.: | ||
|
|
||
| - `patch` | ||
| - Would bump `0.3.0` -> `0.3.1` | ||
| - `minor` | ||
| - Would bump `0.3.0` -> `0.4.0` | ||
| - `major` | ||
| - Would bump `0.3.0` -> `1.0.0` | ||
|
|
||
| ## Release assets | ||
|
|
||
| JupyterGIS is published to: | ||
|
|
||
| - PyPI: | ||
| - <https://pypi.org/project/jupytergis/>: A metapackage. | ||
| - Conda Forge | ||
| - <https://github.com/conda-forge/jupytergis-packages-feedstock> | ||
| - npm: | ||
| - <https://www.npmjs.com/package/@jupytergis/base> | ||
| - <https://www.npmjs.com/package/@jupytergis/schema> | ||
| - <https://www.npmjs.com/package/@jupytergis/jupytergis-core> | ||
| - <https://www.npmjs.com/package/@jupytergis/jupytergis-lab> | ||
| - <https://www.npmjs.com/package/@jupytergis/jupytergis-qgis> | ||
|
|
||
| Release assets are also available on GitHub. For example for | ||
| [`0.3.0`](https://github.com/geojupyter/jupytergis/releases/tag/v0.3.0): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| =============== | ||
| Troubleshooting | ||
| =============== | ||
|
|
||
| * Setup of development environment hangs indefinitely when running the | ||
| ``dev-install.py`` step, specifically on the Yarn linking step. | ||
|
|
||
| * This may be caused by having a ``.gitignore`` file in your home directory. | ||
| This is a `known issue with Nx <https://github.com/nrwl/nx/issues/27494>`_. | ||
| The `only known workaround <https://github.com/nrwl/nx/issues/27494#issuecomment-2481207598>`_ is to remove the ``.gitignore`` file from your home directory or to work in a location outside of the home directory tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Features | ||
|
|
||
| ```{toctree} | ||
| :maxdepth: | ||
|
|
||
| extension.rst | ||
| collab.rst | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # User guide | ||
|
|
||
| Thanks for trying out JupyterGIS! | ||
|
|
||
| ```{cssclass} try-in-jupyterlite-button | ||
|
|
||
| [Try it with JupyterLite!](lite/) | ||
| ``` | ||
|
|
||
| JupyterGIS offers: | ||
|
|
||
| - **Collaborative GIS Environment**: Work together on geographic data projects in real-time. | ||
| - **QGIS File Support**: Load, visualize, and manipulate QGIS project files (`.qgs`, `.qgz`), and other GIS data formats. | ||
| - **Interactive Maps**: Render interactive maps and geospatial visualizations within Jupyter notebooks using the JupyterGIS Python API. | ||
|
|
||
| ```{toctree} | ||
| :maxdepth: 2 | ||
|
|
||
| install | ||
| tutorials/index | ||
| features/index | ||
| python_api | ||
| ``` | ||
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Tutorials | ||
|
|
||
| ```{toctree} | ||
| :maxdepth: 2 | ||
| :glob: | ||
|
|
||
| * | ||
| ``` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced by that
featurespart.I wonder if we could not have
extensionandcollaborationat top level.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought process for this change was that this content (
extensionandcollaboration) fall under the category of "explanation", and the audience is end-users. For that reason I thought (1) these things belong in the user guide; (2) it made sense to group these two things together in a directory where we can continue adding more explanatory content in the future.What do you think about my reasoning?
Alternatively, what about grouping these documents under a "tour" or "About > Why JGIS?" structure? Some of the wordy content on the document index may also feel at home in a "About" section.