Skip to content

Fix categorized symbology#430

Merged
gjmooney merged 2 commits intogeojupyter:mainfrom
gjmooney:symbology_fix
Feb 4, 2025
Merged

Fix categorized symbology#430
gjmooney merged 2 commits intogeojupyter:mainfrom
gjmooney:symbology_fix

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Feb 4, 2025

Description

Fixes #429

Adds a check of the layer type and uses the correct attribute for the style expression.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--430.org.readthedocs.build/en/430/
💡 JupyterLite preview: https://jupytergis--430.org.readthedocs.build/en/430/lite

@gjmooney gjmooney added the bug Something isn't working label Feb 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/symbology_fix

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Integration tests report: appsharing.space

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjmooney, Looks good to me :)

@gjmooney gjmooney merged commit afc733a into geojupyter:main Feb 4, 2025
14 checks passed
@gjmooney gjmooney deleted the symbology_fix branch February 4, 2025 10:04
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Fix categorized symbology

* Refresh examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Categorised Rendering doesn't work with polygon vector

2 participants