Add a visual indicator when layers aren't successfully rendered#462
Open
Meriem-BenIsmail wants to merge 4 commits intogeojupyter:mainfrom
Open
Add a visual indicator when layers aren't successfully rendered#462Meriem-BenIsmail wants to merge 4 commits intogeojupyter:mainfrom
Meriem-BenIsmail wants to merge 4 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
mfisher87
reviewed
Feb 12, 2025
Member
mfisher87
left a comment
mfisher87
left a comment
There was a problem hiding this comment.
Nice work :) A couple of thoughts, hopefully not too onerous!
| onDragOver={Private.onDragOver} | ||
| onDragEnd={Private.onDragEnd} | ||
| data-id={layerId} | ||
| style={{ textDecoration: layer.failed ? 'line-through' : 'none' }} |
Member
There was a problem hiding this comment.
What do you think about displaying a warning icon
Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #415.
Also this PR adds error handling when updating the source.
gis.webm
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--462.org.readthedocs.build/en/462/
💡 JupyterLite preview: https://jupytergis--462.org.readthedocs.build/en/462/lite