Skip to content

Continue installing the labextension in the dev install script#463

Merged
martinRenou merged 2 commits intogeojupyter:mainfrom
arjxn-py:fix-metapackage-install
Feb 12, 2025
Merged

Continue installing the labextension in the dev install script#463
martinRenou merged 2 commits intogeojupyter:mainfrom
arjxn-py:fix-metapackage-install

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 12, 2025

Description

Coming from jupytercad/JupyterCAD#681 (comment)

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--463.org.readthedocs.build/en/463/
💡 JupyterLite preview: https://jupytergis--463.org.readthedocs.build/en/463/lite

@arjxn-py arjxn-py requested a review from martinRenou February 12, 2025 15:30
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/fix-metapackage-install

@arjxn-py
Copy link
Member Author

For some reason i've some diff in yarn.lock file too while doing jlpm install -
image

@arjxn-py arjxn-py added the maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc. label Feb 12, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Member

Ah! Can you please commit the yarn.lock, I get it's an oversight of #459

1 similar comment
@martinRenou
Copy link
Member

Ah! Can you please commit the yarn.lock, I get it's an oversight of #459

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Integration tests report: appsharing.space

@martinRenou martinRenou merged commit 4066be9 into geojupyter:main Feb 12, 2025
12 checks passed
@arjxn-py arjxn-py deleted the fix-metapackage-install branch March 16, 2025 13:06
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
…pyter#463)

* Continue installing the labextension in the dev install script

* update lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants