Fix "Try it with JupyterLite" button in user guide#470
Fix "Try it with JupyterLite" button in user guide#470mfisher87 merged 7 commits intogeojupyter:mainfrom
Conversation
|
Integration tests report: appsharing.space |
|
With da6ca65, the generated URL is However, the button renders extremely inaccessibly. The white-on-yellow text is almost impossible for me to read with excellent vision ( 🤜 🪵 ). Contrast is 1.34:1 when WCAG AA guidelines specify a minimum of 4.5:1. |
Weird... RTD hiccup? EDIT: Yes, re-running the build fixed it. |
It's unclear why, but out-of-the-box, the jupyterlite-sphinx "jupyterlite" directive produces an unstyled button.
There was a problem hiding this comment.
CSS copied from jupyterlite-sphinx project's docs
arjxn-py
left a comment
There was a problem hiding this comment.
Thanks for this and the followed you opened on jupyterlite-sphinx. Looks Good to me :)
|
Thanks for the review! ❤️ |

It was a relative link but lite is installed at the root. The button on the index page works fine, but the button in the user guide doesn't work.
Replacing with
/litealso doesn't work (see comments below). I switched to using thejupyterlitedirective provided byjupyterlite-sphinx. Pretty sweet, but it doesn't include CSS. I opened a PR on thejupyterlite-sphinxrepo to fix a constrast issue with their CSS and also ask about why the CSS wasn't bundled: jupyterlite/jupyterlite-sphinx#269📚 Documentation preview: https://jupytergis--470.org.readthedocs.build/en/470/
💡 JupyterLite preview: https://jupytergis--470.org.readthedocs.build/en/470/lite