Enable downloading a vectorlayer#528
Merged
martinRenou merged 18 commits intogeojupyter:mainfrom Mar 13, 2025
Merged
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
arjxn-py
changed the title
arjxn-py
changed the title
arjxn-py
changed the title
This was referenced Mar 12, 2025
Merged
martinRenou
requested changes
Mar 13, 2025
Member
Author
|
Coming from #532, i've also removed download as geotiff for now |
arjxn-py
changed the title
martinRenou
reviewed
Mar 13, 2025
Comment on lines
-305
to
-307
| if (Object.keys(selectedLayers).length > 1) { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
We don't have this logic anymore. How about putting this logic in getSelectedLayer and maybe rename getSelectedLayer into getSingleSelectedLayer (or something else that makes more sense if you have ideas)?
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* Enable exporting and downloading a layer * make geotiff work * let user decide the name * just geojson and tif for now * schema for exportlayer * cleanup and refactoring * Major Refactor * reuse methods in buffer * lint * rename formdialog * more refactoring * rename method * check sourcetype * lint * one more check * Remove download as geotiff for now * rename getselectedlayer and add check for selected layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
downloadGrojson.mov
Might close #520
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--528.org.readthedocs.build/en/528/
💡 JupyterLite preview: https://jupytergis--528.org.readthedocs.build/en/528/lite