Skip to content

Feat:- Adding key shortcut i to identity#581

Merged
martinRenou merged 2 commits intogeojupyter:mainfrom
nakul-py:identifer
Mar 31, 2025
Merged

Feat:- Adding key shortcut i to identity#581
martinRenou merged 2 commits intogeojupyter:mainfrom
nakul-py:identifer

Conversation

@nakul-py
Copy link
Collaborator

@nakul-py nakul-py commented Mar 28, 2025

Description

This pr implements the 'i' key shortcut to identify command. The identify command should now activates and deactivates with 'i' key and also deactivates by 'escape' key.

Video

Screencast.From.2025-03-28.17-43-02.mp4

closes #575

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--581.org.readthedocs.build/en/581/
💡 JupyterLite preview: https://jupytergis--581.org.readthedocs.build/en/581/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch nakul-py/jupytergis/identifer

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

@arjxn-py arjxn-py added the enhancement New feature or request label Mar 28, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@martinRenou martinRenou merged commit 06c3e1f into geojupyter:main Mar 31, 2025
13 of 16 checks passed
@mfisher87
Copy link
Member

Woo! That's an easy one to implement. I'm thinking I'll make a quick contributor tutorial for this.

@nakul-py nakul-py deleted the identifer branch March 31, 2025 16:57
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* feat:- Adding key shortcut i to identity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard shortcut: i to identify!

4 participants