Skip to content

Processing: Option to save output layer by the side#589

Merged
martinRenou merged 10 commits intogeojupyter:mainfrom
arjxn-py:homogenous-file-handling
Apr 4, 2025
Merged

Processing: Option to save output layer by the side#589
martinRenou merged 10 commits intogeojupyter:mainfrom
arjxn-py:homogenous-file-handling

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Apr 1, 2025

Description

embedOutputLayer.mp4

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--589.org.readthedocs.build/en/589/
💡 JupyterLite preview: https://jupytergis--589.org.readthedocs.build/en/589/lite

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/homogenous-file-handling

@arjxn-py arjxn-py requested a review from martinRenou April 1, 2025 12:20
@arjxn-py arjxn-py added the enhancement New feature or request label Apr 1, 2025
@arjxn-py arjxn-py changed the title Save output layer by the side instead of embedding into the jgis file Processing: Save output layer by the side instead of embedding into the jgis file Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Integration tests report: appsharing.space

@martinRenou
Copy link
Member

As discussed during the last dev meeting, would you like to add a checkbox in the processing form to make this optional?

We can look into saving the user choice in cache in a follow-up PR.

@arjxn-py
Copy link
Member Author

arjxn-py commented Apr 2, 2025

As discussed during the last dev meeting, would you like to add a checkbox in the processing form to make this optional?

Yes, i'm working on this

We can look into saving the user choice in cache in a follow-up PR.

Sure

@arjxn-py arjxn-py changed the title Processing: Save output layer by the side instead of embedding into the jgis file Processing: Option to save output layer by the side Apr 2, 2025
@martinRenou martinRenou force-pushed the homogenous-file-handling branch from 8cfc102 to 461a91e Compare April 3, 2025 06:25
@arjxn-py
Copy link
Member Author

arjxn-py commented Apr 3, 2025

Failure, is again due to the flaky snapshot. Let's try updating that in this PR

@arjxn-py
Copy link
Member Author

arjxn-py commented Apr 3, 2025

Bot please update snapshots

@arjxn-py
Copy link
Member Author

arjxn-py commented Apr 3, 2025

How come a lot of snapshots updated?
Anyways i'm triggering the CI for now

@arjxn-py arjxn-py closed this Apr 3, 2025
@arjxn-py arjxn-py reopened this Apr 3, 2025
@arjxn-py arjxn-py force-pushed the homogenous-file-handling branch from 42486bc to 461a91e Compare April 3, 2025 13:33
@arjxn-py arjxn-py requested a review from martinRenou April 3, 2025 15:33
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 8a435c8 into geojupyter:main Apr 4, 2025
14 checks passed
@arjxn-py arjxn-py deleted the homogenous-file-handling branch April 27, 2025 17:04
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Save output layer by the side instead of embedding into the jgis file

* Minimal buffer process form

* embedOutputLayer?

* handle `embedOutputLayer`

* lint

* default true

* push schema

* define `embedOutputLayer` in schema

* not needed

* Remove bufferProcessForm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants