Skip to content

Add save_as() method to GISDocument API#595

Merged
martinRenou merged 3 commits intogeojupyter:mainfrom
mfisher87:save-as
Apr 2, 2025
Merged

Add save_as() method to GISDocument API#595
martinRenou merged 3 commits intogeojupyter:mainfrom
mfisher87:save-as

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Apr 1, 2025

Description

  • Add save_as() method to GISDocument API. Enables to create an "anonymous" JupyterGIS document and then save it later.
  • Add path attribute (type Path| None) to GISDocument API.
  • 📣 BREAKING: Remove export_to_qgis() method from GISDocument API. This is now consolidated under save_as(); if the filepath passed to save_as() ends in .qgz, it will be a QGIS export.

Resolves #593

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--595.org.readthedocs.build/en/595/
💡 JupyterLite preview: https://jupytergis--595.org.readthedocs.build/en/595/lite

@mfisher87 mfisher87 added the enhancement New feature or request label Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/save-as

mfisher87 and others added 3 commits April 1, 2025 17:57
Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>
Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>
Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Integration tests report: appsharing.space

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 7702cdf into geojupyter:main Apr 2, 2025
14 checks passed
@mfisher87 mfisher87 deleted the save-as branch April 2, 2025 13:59
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Add "save_as" method to GISDocument API

Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>

* Consolidate export to QGIS functionality into `save_as()`

Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>

* Add unit test and fix bug

Co-Authored-By: Arjun Verma <arjxn.py@gmail.com>

---------

Co-authored-by: Arjun Verma <arjxn.py@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add save_as() method to GISDocument API

2 participants