Skip to content

Temporarily change identify keybinding to "Accel+I" to work around bug #592#600

Merged
martinRenou merged 1 commit intogeojupyter:mainfrom
mfisher87:workaround-safe-keybinding
Apr 3, 2025
Merged

Temporarily change identify keybinding to "Accel+I" to work around bug #592#600
martinRenou merged 1 commit intogeojupyter:mainfrom
mfisher87:workaround-safe-keybinding

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Apr 2, 2025

Description

This is a workaround only to enable users to type in Notebooks again!

See: #592 (Important: This PR does not resolve the underlying bug, do not close that issue 😄)

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--600.org.readthedocs.build/en/600/
💡 JupyterLite preview: https://jupytergis--600.org.readthedocs.build/en/600/lite

@mfisher87 mfisher87 added the bug Something isn't working label Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/workaround-safe-keybinding

@mfisher87 mfisher87 changed the title Change identify keybinding to work around bug #592 Temporarily change identify keybinding to work around bug #592 Apr 2, 2025
@mfisher87 mfisher87 changed the title Temporarily change identify keybinding to work around bug #592 Temporarily change identify keybinding to "Accel+I" to work around bug #592 Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Integration tests report: appsharing.space

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@martinRenou martinRenou merged commit 5e86591 into geojupyter:main Apr 3, 2025
29 of 30 checks passed
@mfisher87 mfisher87 deleted the workaround-safe-keybinding branch April 3, 2025 13:29
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants