Use only relevant selectors for keybindings to prevent conflicts#603
Merged
martinRenou merged 3 commits intogeojupyter:mainfrom Apr 7, 2025
Merged
Use only relevant selectors for keybindings to prevent conflicts#603martinRenou merged 3 commits intogeojupyter:mainfrom
martinRenou merged 3 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
Member
|
Can you provide some more context on why this works? |
Member
Author
Yes, The previous implementation of the I have removed it from app shell and just added it to the mainview and left & right panel instead - so that keybindings only work where they're supposed to and do not conflict with other keybindings. |
Member
|
That makes sense, thanks! |
mfisher87
approved these changes
Apr 6, 2025
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
…jupyter#603) * Use only relevant selectors for keybindings to prevent conflicts * my bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #592
key.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--603.org.readthedocs.build/en/603/
💡 JupyterLite preview: https://jupytergis--603.org.readthedocs.build/en/603/lite