Skip to content

Add scrollbar to the identify panel #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfisher87 merged 2 commits into from
Apr 9, 2025
Merged

Add scrollbar to the identify panel #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fcacc7
Add scrollbar to the identify panel
arjxn-py Apr 7, 2025
54d8226
Merge branch 'main' into identify-scroll
arjxn-py Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/base/src/panelview/annotationPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class Annotations extends PanelWithToolbar {
super({});

this.title.label = 'Annotations';
this.addClass('jGIS-Annotations');
this.addClass('jgis-scrollable');
Copy link
Member

@mfisher87 mfisher87 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noticed a mix of capitalization patterns in the CSS classes.


this._annotationModel = options.annotationModel;
this._rightPanelModel = options.rightPanelModel;
Expand Down
1 change: 1 addition & 0 deletions packages/base/src/panelview/rightpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export class RightPanelWidget extends SidePanel {
});
identifyPanel.title.caption = 'Identify';
identifyPanel.title.label = 'Identify';
identifyPanel.addClass('jgis-scrollable');
this.addWidget(identifyPanel);

this._model.documentChanged.connect((_, changed) => {
Expand Down
10 changes: 6 additions & 4 deletions python/jupytergis_lab/style/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
}

.jGIS-sidepanel-widget {
Copy link
Member

@mfisher87 mfisher87 Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this and jgis-scrollable?

overflow: auto;
height: 100%;
}

Expand Down Expand Up @@ -252,10 +253,6 @@ div.jGIS-toolbar-widget > div.jp-Toolbar-item:last-child {
overflow: auto;
}

.jGIS-Annotations {
overflow: auto;
}

.jGIS-Annotation-Card {
max-height: 400px;
overflow: auto;
Expand Down Expand Up @@ -739,6 +736,11 @@ div.jGIS-toolbar-widget > div.jp-Toolbar-item:last-child {
padding-bottom: 8px;
}

.jgis-scrollable {
overflow: auto;
height: 100%;
}

/* Style the file path text */
.file-container {
display: flex;
Expand Down
Loading