Skip to content

Use svg icons for the main view toolbar#627

Merged
SylvainCorlay merged 3 commits intogeojupyter:mainfrom
HaudinFlorence:use_svg_icons_of_the_main_view_toolbar
Apr 14, 2025
Merged

Use svg icons for the main view toolbar#627
SylvainCorlay merged 3 commits intogeojupyter:mainfrom
HaudinFlorence:use_svg_icons_of_the_main_view_toolbar

Conversation

@HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Apr 14, 2025

This PR proposes some changes in the icons of the main view toolbar:

  • it fixes some vertical centering issues
  • it homogenizes the color for all icons

Screenshot From 2025-04-14 11-36-55
Screenshot From 2025-04-14 11-37-06


📚 Documentation preview: https://jupytergis--627.org.readthedocs.build/en/627/
💡 JupyterLite preview: https://jupytergis--627.org.readthedocs.build/en/627/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch HaudinFlorence/jupytergis/use_svg_icons_of_the_main_view_toolbar

@github-actions
Copy link
Contributor

Integration tests report: appsharing.space

@arjxn-py arjxn-py added the enhancement New feature or request label Apr 14, 2025
@arjxn-py
Copy link
Member

Bot please update snapshots

@SylvainCorlay SylvainCorlay merged commit d69ba7f into geojupyter:main Apr 14, 2025
2 checks passed
@martinRenou
Copy link
Member

We should figure out why the bot introduced new snapshots. There may be an issue with the bot, or we should remove outdated snapshots names?

HaudinFlorence added a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Use svg icons instead of fontawesome icon classes for the toolbar of the mainview

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants