Use full height space when displaying widget in linked view or sidecar#645
Closed
mfisher87 wants to merge 1 commit intogeojupyter:mainfrom
Closed
Use full height space when displaying widget in linked view or sidecar#645mfisher87 wants to merge 1 commit intogeojupyter:mainfrom
mfisher87 wants to merge 1 commit intogeojupyter:mainfrom
Conversation
Linked view can be opened by right-clicking the gutter space to the left of a widget and selecting "Create new view for cell output". Sidecar view can be opened with [jupyterlab-sidecar](https://github.com/jupyter-widgets/jupyterlab-sidecar).
Contributor
|
|
Member
|
Looks like a duplicate of #643 :) |
Contributor
|
Integration tests report: appsharing.space |
Member
Author
|
Yep! I didn't realize Sylvain had opened that PR, still waking up 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when displaying a GISDocument widget, it will always have a fixed height of
600px. This is problematic when opening the widget in a sidecar or a "linked output" view, as the widget will either take up a small portion of the height of the container or it will extend beyond the bottom of the container and require the user to scroll.This PR sets the height to 100% in both of those contexts.
"Linked output" view can be opened by right-clicking the gutter space to the left of a widget and selecting "Create new view for cell output".
Sidecar view can be opened with jupyterlab-sidecar.
Thanks @SylvainCorlay for pointing me in the right direction 🚀
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--645.org.readthedocs.build/en/645/
💡 JupyterLite preview: https://jupytergis--645.org.readthedocs.build/en/645/lite