Support identifying features in vector tile layers#852
Support identifying features in vector tile layers#852arjxn-py merged 8 commits intogeojupyter:mainfrom
Conversation
eb1db7c to
a2ad96b
Compare
|
Integration tests report: appsharing.space |
arjxn-py
left a comment
There was a problem hiding this comment.
Thanks @Gauss-Taylor-Euler
The identify feature works but the identified feature dont get highlighted
The reason why we have not been able to make the highlight thing work is because we don't have the geometry data for the feature we want to highlight - you might want to use toGeometry from openlayers to convert RenderFeature to Feature - https://openlayers.org/en/latest/apidoc/module-ol_render_Feature.html
Or you can just reuse the method I defined over here once it's merged or just copy in your case for now - https://github.com/geojupyter/jupytergis/pull/854/files#diff-d610e45bb2cb68b897b52b1cb7e651ed8dbc8088d8f544fa5f0d4d8285ae4441R837-R854
I tried a simpler highlighting method like the one used for WebGLLayer (where you only highlight the point clicked) : Identify.demo.vector.tile.mp4 |
3396f59 to
449e7a8
Compare
|
So I made modification to take into account the other methods , now if there is a geometry it will highlight it otherwise it will highlight the point clicked here is a demo : identify.new.demo.mp4 |
Neat, this is much better 🚀 |
37afa8e to
d2c9cf1
Compare
arjxn-py
left a comment
There was a problem hiding this comment.
Thanks @Gauss-Taylor-Euler. Just a small nitpick for readability
* Restore earthquakes.jGIS example * Made identify features work with vector tile * Solve lint * Made suggested changes and add simple highlighting * Made suggested changes * Better highlighting logic * Update packages/base/src/mainview/mainView.tsx * lint --------- Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com> Co-authored-by: arjxn-py <arjxn.py@gmail.com>
Identify panel on vector tile
Made identify panel work on vector tile.
Checklist
Resolves #XXX.📚 Documentation preview: https://jupytergis--852.org.readthedocs.build/en/852/
💡 JupyterLite preview: https://jupytergis--852.org.readthedocs.build/en/852/lite