Skip to content

Support identifying features in vector tile layers#852

Merged
arjxn-py merged 8 commits intogeojupyter:mainfrom
Gauss-Taylor-Euler:identify_vector_tile
Aug 13, 2025
Merged

Support identifying features in vector tile layers#852
arjxn-py merged 8 commits intogeojupyter:mainfrom
Gauss-Taylor-Euler:identify_vector_tile

Conversation

@Gauss-Taylor-Euler
Copy link
Contributor

@Gauss-Taylor-Euler Gauss-Taylor-Euler commented Aug 7, 2025

Identify panel on vector tile

Made identify panel work on vector tile.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.

📚 Documentation preview: https://jupytergis--852.org.readthedocs.build/en/852/
💡 JupyterLite preview: https://jupytergis--852.org.readthedocs.build/en/852/lite

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Binder 👈 Launch a Binder on branch Gauss-Taylor-Euler/jupytergis/identify_vector_tile

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py added the enhancement New feature or request label Aug 7, 2025
@mfisher87 mfisher87 changed the title Identify panel vector tile Support identifying features in vector tile layers Aug 7, 2025
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gauss-Taylor-Euler
The identify feature works but the identified feature dont get highlighted

The reason why we have not been able to make the highlight thing work is because we don't have the geometry data for the feature we want to highlight - you might want to use toGeometry from openlayers to convert RenderFeature to Feature - https://openlayers.org/en/latest/apidoc/module-ol_render_Feature.html

Or you can just reuse the method I defined over here once it's merged or just copy in your case for now - https://github.com/geojupyter/jupytergis/pull/854/files#diff-d610e45bb2cb68b897b52b1cb7e651ed8dbc8088d8f544fa5f0d4d8285ae4441R837-R854

@Gauss-Taylor-Euler
Copy link
Contributor Author

Thanks @Gauss-Taylor-Euler The identify feature works but the identified feature dont get highlighted

The reason why we have not been able to make the highlight thing work is because we don't have the geometry data for the feature we want to highlight - you might want to use toGeometry from openlayers to convert RenderFeature to Feature - https://openlayers.org/en/latest/apidoc/module-ol_render_Feature.html

Or you can just reuse the method I defined over here once it's merged or just copy in your case for now - https://github.com/geojupyter/jupytergis/pull/854/files#diff-d610e45bb2cb68b897b52b1cb7e651ed8dbc8088d8f544fa5f0d4d8285ae4441R837-R854

I tried a simpler highlighting method like the one used for WebGLLayer (where you only highlight the point clicked) :

Identify.demo.vector.tile.mp4

@Gauss-Taylor-Euler
Copy link
Contributor Author

So I made modification to take into account the other methods , now if there is a geometry it will highlight it otherwise it will highlight the point clicked here is a demo :

identify.new.demo.mp4

@arjxn-py
Copy link
Member

So I made modification to take into account the other methods , now if there is a geometry it will highlight it otherwise it will highlight the point clicked

Neat, this is much better 🚀

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gauss-Taylor-Euler. Just a small nitpick for readability

@arjxn-py arjxn-py merged commit fe750d8 into geojupyter:main Aug 13, 2025
14 checks passed
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Restore earthquakes.jGIS example

* Made identify features work with vector tile

* Solve lint

* Made suggested changes and add simple highlighting

* Made suggested changes

* Better highlighting logic

* Update packages/base/src/mainview/mainView.tsx

* lint

---------

Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Co-authored-by: arjxn-py <arjxn.py@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants