Make VectorTiles downloadable as GeoJSON#854
Open
arjxn-py wants to merge 5 commits intogeojupyter:mainfrom
Open
Make VectorTiles downloadable as GeoJSON#854arjxn-py wants to merge 5 commits intogeojupyter:mainfrom
arjxn-py wants to merge 5 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
arjxn-py
changed the title
Contributor
|
Integration tests report: appsharing.space |
gjmooney
requested changes
Aug 13, 2025
Comment on lines
+844
to
+852
| const geometry = toGeometry(rf); | ||
|
|
||
| if (!geometry) { | ||
| continue; | ||
| } | ||
|
|
||
| const feature = new Feature<Geometry>({ ...properties }); | ||
| feature.setGeometry(geometry); | ||
| features.push(feature); |
Collaborator
There was a problem hiding this comment.
Does OL's toFeature method work here?
Member
There was a problem hiding this comment.
Have you had the time to try it? Is it ready for another review/merge?
Co-authored-by: Greg Mooney <gregory.mooney@quantstack.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2025-08-12.at.12.36.22.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--854.org.readthedocs.build/en/854/
💡 JupyterLite preview: https://jupytergis--854.org.readthedocs.build/en/854/lite