Skip to content

Add a flag to hide STAC browser#855

Merged
arjxn-py merged 4 commits intogeojupyter:mainfrom
arjxn-py:flag-hide-stac
Aug 12, 2025
Merged

Add a flag to hide STAC browser#855
arjxn-py merged 4 commits intogeojupyter:mainfrom
arjxn-py:flag-hide-stac

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Aug 7, 2025

Description

Seems to work well when i test it with the lite deployment:

12660

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--855.org.readthedocs.build/en/855/
💡 JupyterLite preview: https://jupytergis--855.org.readthedocs.build/en/855/lite

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/flag-hide-stac

@arjxn-py arjxn-py added the enhancement New feature or request label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Integration tests report: appsharing.space

@mfisher87
Copy link
Member

What's the use case for this? Do you think we should have flags for hiding all the different panels?

@arjxn-py
Copy link
Member Author

arjxn-py commented Aug 8, 2025

What's the use case for this? Do you think we should have flags for hiding all the different panels?

Yes the goal would be this and this is a proof of concept for that
The use case is to give the ability to users to hide things that are not relevant for their use case.

@arjxn-py arjxn-py marked this pull request as ready for review August 8, 2025 14:52
@arjxn-py arjxn-py requested a review from gjmooney August 8, 2025 14:52
@arjxn-py arjxn-py marked this pull request as draft August 8, 2025 14:53
@mfisher87
Copy link
Member

The use case is to give the ability to users to hide things that are not relevant for their use case.

I guess I mean more specifically, is there a user asking for this, and what is their reason they need it? Especially since the STAC browser is now under a tab, I'm not personally seeing value or urgency in hiding it so I'd like to understand the perspective of whomever is asking for this!

@arjxn-py
Copy link
Member Author

The use case is to give the ability to users to hide things that are not relevant for their use case.

I guess I mean more specifically, is there a user asking for this, and what is their reason they need it? Especially since the STAC browser is now under a tab, I'm not personally seeing value or urgency in hiding it so I'd like to understand the perspective of whomever is asking for this!

Yes a potential user were asking for this, I'm not sure if they are here on github though. The reasoning was to not overwhelm the end user with the things that are not relevant for them.

We agreed because it doesn't affect our api and does not mess with the users who are already using stac browser but just give them an addon ability to hide it if they want to

@arjxn-py arjxn-py marked this pull request as ready for review August 11, 2025 06:17
@mfisher87
Copy link
Member

Thanks for the additional context!

@mfisher87
Copy link
Member

mfisher87 commented Aug 11, 2025

What do you think of a single variable HIDE_PANEL_TABS? E.g. HIDE_PANEL_TABS=stac,identify? As we go forward, I imagine having a flag for each panel will be unwieldy. I think if we go this way it's fine if we only support stac as a value for now.

@arjxn-py
Copy link
Member Author

What do you think of a single variable HIDE_PANEL_TABS? E.g. HIDE_PANEL_TABS=stac,identify? As we go forward, I imagine having a flag for each panel will be unwieldy. I think if we go this way it's fine if we only support stac as a value for now.

Yes, I plan to do similar in follow up PRs

@arjxn-py arjxn-py merged commit f930954 into geojupyter:main Aug 12, 2025
14 checks passed
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Add a flag to hide STAC browser

* lint

* try passing the flag through config

* Update docs/jupyter-lite.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants