Skip to content

Fix double click bug while identifying vectorTileLayers #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 3 commits into from
Aug 27, 2025
Merged

Fix double click bug while identifying vectorTileLayers #908

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c22da24
Fix double click bug while identifying vectorTileLayers
arjxn-py Aug 27, 2025
e926b6c
move property to bottom
arjxn-py Aug 27, 2025
b991898
Add TODO comment
martinRenou Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions packages/base/src/mainview/mainView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,30 +2104,48 @@ export class MainView extends React.Component<IProps, IStates> {
case 'VectorTileLayer': {
const geometries: Geometry[] = [];
const features: any[] = [];
let foundAny = false;

this._Map.forEachFeatureAtPixel(e.pixel, (feature: FeatureLike) => {
foundAny = true;

let geom: Geometry | undefined;
let props = {};

if (feature instanceof RenderFeature) {
geom = toGeometry(feature);
} else if ('getGeometry' in feature) {
geom = feature.getGeometry();
}

const props = feature.getProperties();
const rawProps = feature.getProperties();
const fid = feature.getId?.() ?? rawProps?.fid;

if (rawProps && Object.keys(rawProps).length > 1) {
const { geometry, ...clean } = rawProps;
props = clean;
if (fid !== null) {
// TODO Clean the cache under some condition?
this._featurePropertyCache.set(fid, props);
}
} else if (fid !== null && this._featurePropertyCache.has(fid)) {
props = this._featurePropertyCache.get(fid);
}

if (geom) {
geometries.push(geom);
}
features.push({
...props,
});
if (props && Object.keys(props).length > 0) {
features.push(props);
}

return true;
});

if (features.length > 0) {
this._model.syncIdentifiedFeatures(features, this._mainViewModel.id);
} else if (!foundAny) {
this._model.syncIdentifiedFeatures([], this._mainViewModel.id);
}

if (geometries.length > 0) {
Expand Down Expand Up @@ -2335,4 +2353,5 @@ export class MainView extends React.Component<IProps, IStates> {
private _state?: IStateDB;
private _formSchemaRegistry?: IJGISFormSchemaRegistry;
private _annotationModel?: IAnnotationModel;
private _featurePropertyCache: Map<string | number, any> = new Map();
}
Loading