Skip to content

Ignore npmjs links in check links CI job#943

Merged
stefanv merged 1 commit intogeojupyter:mainfrom
mfisher87:fix-check-links
Oct 1, 2025
Merged

Ignore npmjs links in check links CI job#943
stefanv merged 1 commit intogeojupyter:mainfrom
mfisher87:fix-check-links

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Oct 1, 2025

Description

Resolves #942

I believe NPM added a new check for user agent which causes our link check job to fail when querying npmjs.com.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--943.org.readthedocs.build/en/943/
💡 JupyterLite preview: https://jupytergis--943.org.readthedocs.build/en/943/lite

@mfisher87 mfisher87 added the maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc. label Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/fix-check-links

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Integration tests report: appsharing.space

@mfisher87
Copy link
Member Author

The medium link also fails to check, but it's flaky. Maybe 1/2 the time, and we usually re-run the job. I think we should probably ignore that link too...

@stefanv stefanv merged commit a142706 into geojupyter:main Oct 1, 2025
44 of 47 checks passed
@mfisher87 mfisher87 deleted the fix-check-links branch October 1, 2025 23:51
nakul-py pushed a commit to nakul-py/jupytergis that referenced this pull request Nov 5, 2025
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Fixing lint errors, changing project metadata, changing tooling, changing dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI link check always fails now

2 participants